Skip to content

TGC-796: Create CheckResponsesPageController#231

Merged
davidatdefra merged 11 commits intomainfrom
TGC-796-check-details-page
Aug 27, 2025
Merged

TGC-796: Create CheckResponsesPageController#231
davidatdefra merged 11 commits intomainfrom
TGC-796-check-details-page

Conversation

@davidatdefra
Copy link
Copy Markdown
Contributor

Fix minor styling issues across the app

Fix minor styling issues across the app
Comment thread src/server/common/forms/definitions/adding-value.yaml
Comment thread src/server/index.js Outdated
@davidatdefra
Copy link
Copy Markdown
Contributor Author

Need to update @defra/forms-engine-plugin dependency version after PR DEFRA/forms-engine-plugin#173 is merged and the new version is available

@swdpcomputing
Copy link
Copy Markdown
Contributor

In general it feels like there's some confusion / conflation / mismatch / inconsistency between details and responses, but that may be my misunderstanding.

Comment thread src/server/check-responses/check-responses.controller.js
@davidatdefra davidatdefra changed the title TGC-796: Create CheckDetailsPageController TGC-796: Create CheckResponsesPageController Aug 27, 2025
Comment thread src/server/confirmation/views/confirmation-page.html Outdated
Comment thread src/server/check-responses/views/check-responses-page.html Outdated
@sonarqubecloud
Copy link
Copy Markdown

@Andrew-Folga Andrew-Folga self-requested a review August 27, 2025 15:40
Copy link
Copy Markdown
Contributor

@Andrew-Folga Andrew-Folga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidatdefra davidatdefra merged commit 3ef4f98 into main Aug 27, 2025
5 checks passed
@davidatdefra davidatdefra deleted the TGC-796-check-details-page branch August 27, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants